You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 7 Next »

Brief summary for landing patch to Lustre:

  1. File a Lustre JIRA ticket describing your change.
  2. Test and commit your patch locally.
  3. Verify patch follows Lustre Coding Guidelines with git show | build/checkpatch.pl - (or install the commit-msg and prepare-commit-msg scripts into .git/hooks)
  4. Push your patch to Gerrit for review, and request at least two reviewers (preferably ones with experience in this area of code) on the Gerrit page for this patch.
  5. Record the change URL in the JIRA ticket (this should happen automatically today for the Lustre project).
  6. Test your patch on real cluster and upload your test results to Maloo (this happens automatically for all patches in the fs/lustre-release project).
  7. Attach additional test results appropriate for the patch being landed to the JIRA ticket (interoperability, performance, etc) if necessary.
  8. Add a comment in Gerrit with the Maloo link to indicate that the patch works, and set the Verified flag (this is done automatically for standard test results).
  9. Solicit and address review comments from patch reviewers until they have given a positive review (it is the patch submitter's responsibility to direct attention to a patch if they feel it isn't making progress).
  10. Add the branch gatekeeper (Gerrit Gatekeeper for fs/lustre-release) as inspector on Gerrit to notify him/her that the patch is ready to be merged.
  11. The branch gatekeeper will review the patch, confirm the test results, and submit it when everything goes well (subject to feature freeze, code freeze, etc.).
  12. If the submission failed due to conflict(s), the gatekeeper will ask you in Gerrit to rebase your patch to the head of target branch and repeat above steps 3 to 11.
  13. If your patch is useful for other branch(es), please repeat above steps against corresponding branch(es) after the patch has landed to master.
  • No labels