Brief summary for landing patch to Lustre:
- File a Lustre JIRA ticket describing your change.
- Test and commit your patch locally.
- Verify patch follows Lustre Coding Guidelines with
git show | build/checkpatch.pl -(and/or symlink the
- Push your patch to Gerrit for review, and
Addat least two reviewers (preferably ones with experience in this area of code) on the Gerrit page for this patch.
- Record the Gerrit change URL in the JIRA ticket (this should happen automatically today for the Lustre project).
- Test your patch on real cluster and upload your test results to the Maloo test results database (this happens automatically for all patches in the
- Attach additional test results appropriate for the patch being landed to the JIRA ticket (interoperability, performance, etc) if necessary.
- Add a comment in Gerrit with the Maloo link to indicate that the patch works, and set the
Verifiedflag (this is done automatically for standard test results).
- Solicit and address review comments from patch reviewers until they have given a positive review (it is the patch submitter's responsibility to direct attention to a patch if they feel it isn't making progress)
- Once the patch has a
Verified: +1label from Maloo and two separate
Code-Review: +1labels from qualified reviewers, the branch gatekeeper will review the patch, confirm the test results, and submit it to the tree (subject to feature freeze, code freeze, etc.).
- If the submission failed due to patch conflict(s), the
HPDD Checkpatchbot or the gatekeeper will ask you in Gerrit to rebase your patch to the head of target branch and repeat above steps 3 to 11.
- If your patch is useful for other branch(es), please repeat above steps against corresponding branch(es) after the patch has landed to master.