Page History

...

Gerrit requires all changes to have the Commit-Id: field, or it will be rejected. It should be added automatically by the .git/hooks/commit-comment script. See Commit Comments for a detailed description of the Commit-Id: field.

Creating Inspection Requests

Submitting Patches for Inspection, Testing, and Landing

A change An inspection request is created by pushing a change patch to a special branch on the Gerrit repository. To create an inspection change request for a change patch in your local branch the local commit (or series of commits) needs to be pushed to the Gerrit review repository.

It is possible to push a series of dependent commits from a local branch in this same way, and each one will create a separate change in Gerrit. Patch series should be used to split complex code changes that are implementing a single larger feature into chunks that are easier to understand. These changes will be dependent on each other, so if one patch needs to be refreshed after an inspection or test failure it will cause all of the later patches to be refreshed also. That will clear all of the inspections inspection and test results and restart testing on all of the patches.

Patch series should not be used for code that was written and then had a series of bug fixes applied to it after local testing. The later (local) bug fixes should be squashed into the original change before submission. Note that each patch in a series must build and test properly before it can be landed, so intermediate bugs or compile warnings or test failures in the middle of a patch series are not allowed.

If you have a series of independent commits to be reviewed, each one should be in a separate local branch and pushed separately to Gerrit. This allows the patches to be inspected, tested, and landed independently, and will avoid the overhead and delay of repeatedly inspecting, building, and testing patches that are only refreshed because of an earlier (unrelated) patch in a series being modified.

...

In order to actually get a patch landed, you need to request at least two inspections in Gerrit for the patch. This is done by visiting the Gerrit web page for the change (at the URL returned when the commit was pushed, or it can be found from the main page after logging in). Enter the name or email address for the inspectors and click the Add Reviewer button.

In conjunction with the two inspection requests, the patch has to successfully build on all supported architecture/distro combinations, and pass the automatic testing (as reported by Maloo). Once the patch has passed two inspections (+1 or +2 Review from inspectors), built correctly (+1 Verified from Hudson/Jenkins), and has passed autotest (+1 Verified from Maloo) the patch can be submitted for landing by adding Gerrit Gatekeeper using the Add Reviewer.

Updating Inspection Requests

...