Page History
...
An inspection request is created by pushing a change to a special branch on the Gerrit repository. For example, to create a To create an inspection request for a change against master on the main lustre repository, you do this your current working branch on your local branch for inspection:in your local branch the local commit (or series of commits) needs to be pushed to the Gerrit review repository.
It is possible to push a series of dependent commits from a local branch in this same way, and each one will create a separate change in Gerrit. These changes will be dependent on each other, so if one patch needs to be refreshed after an inspection it will cause all of the later patches to be refreshed also. That will clear all of the inspections and restart testing on all of the patches.
If you have a series of independent commits to be reviewed, each one should be in a separate local branch and pushed separately to Gerrit. This allows the patches to be inspected, tested, and landed independently, and will avoid the overhead and delay of repeatedly inspecting, building, and testing patches that are only refreshed because of an earlier (unrelated) patch in a series being modified.
| No Format |
|---|
git push ssh://USER@review.whamcloud.com:29418/fs/lustre-release HEAD:refs/for/master |
...
| No Format |
|---|
$ git remote add review ssh://review/fs/lustre-release |
Requesting inspections
When the patch has been pushed to the Gerrit review repository, it will print a URL for that change set that should be added to the bug for this change in Jira for tracking. The patch will be automatically built on the supported CPU architectures and Linux distributions by Jenkins (formerly Hudson), and then tested on one of the systems in the Whamcloud test cluster.
In order to actually get a patch landed, you need to request at least two inspections in Gerrit for the patch. This is done by visiting the [http://review.whamcloud.com/] for the change (at the URL returned when the commit was pushed, or it can be found from the main page after logging in). Enter the email address for the inspectors and click the Add Reviewer button.
In conjunction with the two inspection requests, the patch has to successfully build on all supported architecture/distro combinations, and pass the automatic testing (as reported by [Using+Maloo]).
Pushing a Git Tag
Switch to the branch you want to create a branch in (normally master or b1_8).
...
Overview
Content Tools