Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Reflect that commit-msg and prepare-commit-msg are now in the main branches

...

Gerrit will automatically identify updates to existing patches and update the existing request instead of creating a new one. This preserves the history of patch comments, and allows comparing old and new versions of a patch for more efficient inspections. For this to work properly the changes you create locally need to have a unique commit id in them. To get this the Commit-Id field inserted automatically, copy the commit-msg hook from the build/ subdirectory into your each Git repository's .git/hooks/ directory. This will update the commit message for changes you commit to your repository before they are submitted to Gerrit. The commit-msg hook will also verify that the commit message format matches the format specified above. Similarly, copying the prepare-commit-msg from build/ to .git/hooks/ will run the build/checkpatch.pl script against the each patch at commit time to check it against the Lustre Coding Guidelines.

Newer versions of Lustre include the commit-msg and prepare-commit-msg hooks in the build/ subdirectory, but they must be copied into each repository by hand. For older Lustre versions it can be downloaded from this page using curl or wget:

No Format

$ curl -o .git/hooks/commit-msg http://wiki.whamcloud.com/download/attachments/7111125/commit-msg
$ curl -o .git/hooks/prepare-commit-msg http://wiki.whamcloud.com/download/attachments/7111125/prepare-commit-msg

Note that you might have to add execute permissions to the hooks once you have fetched them:

...

For older Lustre versions that are missing the commit hooks, they can be copied from a newer branch of Lustre (e.g. master), and the .git/hooks/ directory is shared among all branches (it is not updated when checking out a new branch).

Creating Inspection Requests

...