Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: add comments about marking Maloo failures

...

All patches submitted to Gerrit will be built automatically by Jenkins (formerly Hudson) with a number of configurations. Currently for the master branch this includes RHEL6 i686/x86_64 client/server, RHEL5 i686/x86_64 client, Ubuntu 10.04 x86_64 client, and SLES11 SP1 x86_64 client. The success/failure of these builds will be posted to the change in Gerrit as a link to the Hudson build artifacts.

After a successful build on all of the configurations, one of the configurations will be regression tested automatically, and a link to the test results in Maloo will be posted to Gerrit. It is also possible to manually post test results to Maloo from manual testingyour own testing.

Automated regression testing for each patch should normally pass.  In some cases it might fail for a variety of reasons, such as a bug in the patch, an intermittent test failure that is present in the existing code, problems with the testing system, etc.  In all failure cases, the Maloo test failure(s) should be investigated as to the root cause.  Once the test failure is identified the Maloo test result should either be linked (Associated) to an existing ticket in Jira, or if necessary a new Jira ticket with details of the failure should be filed (Raised), and a comment added to Gerrit with the JIRA LU ticket number.  At this point the test could be resubmitted, if there are no other problems with the patch, or it can be refreshed if there are inspection comments that need to be addressed (per below).

Requesting inspections

In order to actually get a patch landed, you need to request at least two inspections in Gerrit for the patch. This is done by visiting the Gerrit web page for the change (at the URL returned when the commit was pushed, or it can be found from the main page after logging in). Enter the name or email address for the inspectors and click the Add Reviewer button.

...