Page tree
Skip to end of metadata
Go to start of metadata

Introduction

There may be times that you wish to influence the building and testing carried out on your change. You might for example be fixing an issue that affects a particular distribution or combination of distributions, for this reason you can change the tests carried out by indicating in the commit message the changes you require. Test Parameter sessions are in addition to the normal tests that would be run against a patch. This allows a patch with specific or unusual testing requirements to ensure that sufficient additional testing is run to gain confidence in the change being made. For patches that are of an experimental nature (i.e. developer is not sure of functionality, or only wants a limited set of tests to be run just to try something), it is also possible to submit a patch with the fortestonly parameter.

To run additional sessions for your patch, add 'Test-Parameters: ' with space-separated name value pairs to your commit message.

For example:

Test-Parameters: envdefinitions=ONLY=32 testlist=conf-sanity

This will cause Autotest to run the normal test sessions plus 1 additional session where only conf-sanity test #32 will run.

Multiple 'Test-Parameters:' lines can be defined:

Test-Parameters: testgroup=review-ldiskfs clientdistro=sles12sp3 serverdistro=sles12sp3
Test-Parameters: testgroup=review-ldiskfs clientdistro=ubuntu1804 serverdistro=el7

Long lists can be catered for by escaping the carriage return:

Test-Parameters: ostcount=2 clients=1 ostsizegb=2 mdssizegb=2 envdefinitions=SLOW=yes \
                 testlist=sanity,liblustre

Quotations can be used when spaces are necessary in a value:

Test-Parameters: testlist=sanity envdefinitions=SANITY_EXCEPT="101g 102i" 


The test parameter sessions can be influenced in many ways, see the General Parameters and Node Parameters sections below for all of the options.


General Parameters

Below is the list of general test parameters that can be used to run custom test sessions. These parameters differ from the node_parameters in that these do not need to be specified with a node type prefix.

For all of the examples below the 'Test-Parameters:' marker has been omitted to simplify the examples.


austeroptions | String

Pass through options for auster.

Valid values: See "Auster usage help" section on the Setting up a Lustre Test Environment wiki.

austeroptions=-R

combinedmdsmgs | Boolean

When true, the MGT will share a partition with an MDT. When false, AT will create an additional partition to be used by just the MGT.

NOTE: mdtfilesystemtype will override mgtfilesystemtype when combinedmdsmgs is true. If standalonemgs is set to true, this option will be ignored.

Valid values: true, false (no value is the same as true)

# creates a shared partition to be used by the MGT and a MDT - typically not necessary since this is the default
combinedmdsmgs
# or
combinedmdsmgs=true

# creates an additional partition to be used by the MGT
combinedmdsmgs=false
envdefinitions | String

Comma separated environment definitions passed to the test environment. For definitions requiring spaces, enclose them in quotations.

NOTE: Be very careful setting environment variables directly (for example OSTFSTYPE=zfs) because Autotest creates a config file based on the environment it builds. If you ask for something at odds with Autotest's expectations you will see failure instead of success.  In this case, for example, you should use the filesystemtype keyword described on this page. Autotest will then create the appropriate environment variables, the same is true for other things like ostcount instead of OSTCOUNT, ostsizegb instead of OSTSIZE, etc. Only use the envdefinitions variable when a direct variable is not listed here.

envdefinitions=SLOW=yes

# multiple definitions, one with spaces that must be enclosed in quotations
envdefinitions=SLOW=yes,SANITY_EXCEPT="101g 102i"
failover | Boolean

Setup cluster in failover configuration

Valid values: true, false (no value is the same as true)

# enable failover
failover
# or
failover=true

# disable failover setup
failover=false
forbuildonly | Boolean

Patch will be built by Jenkins but Autotest will not run any testing.

Valid values: true, false (no value is the same as true)

# mark build as for build only
forbuildonly
# or
forbuildonly=true

# disable forbuildonly - typically not necessary since the default is false
forbuildonly=false

fortestonly | Boolean

The fortestonly parameter marks that the patch is not intended for landing. Any testlist= specified with Test-Parameters: fortestonly will replace the default tests that will be run, so it is possible to run only a subset of tests.  Patches marked with fortestonly will not receive the Verified label from Maloo and cannot be landed. In order to land such a patch, it should be rebased and submitted without the fortestonly keyword once the patch is known to be good, or the commit comment in Gerrit should be edited to remove the fortestonly label which will rebuild and retest the patch and will preserve any reviews that the patch has received).

Valid values: true, false (no value is the same as true)

# mark build as for test only
fortestonly
# or
fortestonly=true

# mark patch as for build only and run a custom list of test
fortestonly testlist=conf-sanity

# disable fortestonly - typically not necessary since the default is false
fortestonly=false

fstype | String

Sets the file system type for all server nodes (MDS, MGS and OSS).

NOTE: fstype should not be used in combination with <mdt/mgt/ost>filesystemtype.

Valid values: ldiskfs, zfs

# set all server nodes to use zfs
fstype=zfs

# set all server nodes to use ldiskfs
fstype=ldiskfs

# this may result in an unexpected configuration
fstype=zfs mdtfilesystemtype=ldiskfs
iscsi | boolean

Use iSCSI for failover testing

Valid values: 0 (no iSCSI), 1 (iSCSI)

# do not setup iscsi
iscsi=0

# setup iscsi
iscsi=1
mdssizegb | Integer

Sets the size of the partitions on the MDS in GB.

Valid values: > 0 and must be an integer. When setting this value, take into consideration your mdtcount value and that most test nodes have ~90GB of disk space.

# configure 2GB partitions on the MDS
mdssizegb=2

mdtcount | Integer

The total number of MDTs across all of the MDSs.

Valid values: 1 - 4 per MDS

# create 4 MDTs per MDS
mdscount=2 mdtcount=8

# create 1 MDT per MDS
mdscount=4 mdtcount=4
mdtfilesystemtype | String

Configure the file system type to use on the MDTs.

NOTE: <mdt/mgt/ost>filesystemtype should not be used in combination with fstype.

Valid values: ldiskfs, zfs

# configure the MDTs to use zfs
mdtfilesystemtype=zfs

# configure the MDTs to use ldiskfs
mdtfilesystemype=ldiskfs

# this may result in an unexpected configuration
fstype=zfs mdtfilesystemtype=ldiskfs
mgssizegb | Integer

Sets the size of the partition on the MGS in GB. This value is only applicable when the session is using a stand alone MGS.

Valid values: > 0 and must be an integer. When setting this value, take into consideration that most test nodes have ~90GB of disk space.

# configure a 2GB partition on the MGS
mgssizegb=2
mgtfilesystemtype | String

Configure the file system type to use on the MGTs.

NOTE: The default value for combinedmdsmgs is true, therefore it must be set to false in order to configure a different file system type for the MGT. Also, <mdt/mgt/ost>filesystemtype should not be used in combination with fstype.

Valid values: ldiskfs, zfs

# configure the MGTs to use zfs
mgtfilesystemtype=zfs combinedmdsmgs=false

# configure the MGTs to use ldiskfs
mgtfilesystemype=ldiskfs combinedmdsmgs=false

# since combinedmdsmgs defaults to true, mgtfilesystemtype will be ignored and
# the MGT will use ldiskfs
mdtfilesystemtype=ldiskfs mgtfilesystemype=zfs
 
# do not do this - may result in an unexpected configuration
fstype=zfs mgtfilesystemtype=ldiskfs
optional | Boolean

Marks the test session as optional: does not impact the verified value from Maloo and is only run if resources are immediately available.

Valid values: true, false (no value is the same as true)

# mark a session as optional
optional
# or
optional=true

# mark a session as required - typically not necessary since false is the default
optional=false

ostcount | Integer

The total number of OSTs across all of the OSSs.

Valid values: 1 - 4 per OSS

# create 4 OSTs per OSS
osscount=2 ostcount=8

# create 1 OST per OSS
osscount=4 ostcount=4
ostfilesystemtype | String

Configure the file system type to use on the OSTs.

NOTE: <mdt/mgt/ost>filesystemtype should not be used in combination with fstype.

Valid values: ldiskfs, zfs

# configure the OSTs to use zfs
ostfilesystemtype=zfs

# configure the OSTs to use ldiskfs
ostfilesystemype=ldiskfs

# do not do this - may result in an unexpected configuration
fstype=zfs ostfilesystemtype=ldiskfs
ostsizegb | Integer

Sets the size of the partitions on the OSS in GB.

Valid values: > 0 and must be an integer. When setting this value, take into consideration your ostcount value and that most test nodes have ~90GB of disk space.

# configure 2GB partitions on the OSS
ostsizegb=2
resumeaftercrash | Boolean

When true, Autotest will continue the session after a suite crashes. The session will continue with the suite following the one that crashed. When false, Autotest will stop the session and upload the results to Maloo immediately.

Valid values: true, false (no value is the same as true)

# configure the session to continue after a suite crashes - typically not necessary since the default is true
resumeaftercrash
# or
resumeaftercrash=true

# configure the session to stop after a suite crashes
resumeaftercrash=false
signofftest | Boolean

Marks the session as enforcing: is used to determine the verified value from Maloo.

Valid values: true, false (no value is the same as true)

# mark the session as enforcing - typically not needed since the default is true
signofftest
# or
signofftest=true

# mark the session as not enforcing
signofftest=false
standalonemgs | Boolean

Provisions a separate test node as the MGS. The MGS will be setup with the same parameters as the MDS unless they're overwritten.

Valid values: true, false (no value is the same as true)

# configure the session to run with a stand alone MGS
standalonemgs
# or
standalonemgs=true

# configure the session to run with the MGS on the MDS but separate partitions
standalonemgs=false combinedmdsmgs=false

# configure the session to run with the MGS on the MDS and have the MGT share
# a partition with a MDT
standalonemgs=false combinedmdsmgs=true

# configure the session to run with a stand alone MGS with a different file
# system type than the OSS and MDS
standalonemgs mgtfilesystemtype=zfs mdtfilesystemtype=ldiskfs ostfilesystemtype

testgroup | String

Configure the test session to run a specific test group. Specifying a test group makes it easy to run a typical test grouping with small modifications since the session will inherit all of the values from the base test with any overrides applied (see the code block below for examples).

NOTE: testgroup can be combined with testlist to run a test group plus additional suites

Valid values: See the Test Groups section for a complete list

# run a typical review-ldiskfs session with a stand alone MGS
testgroup=review-ldiskfs standalonemgs

# run failover with a specific server version
testgroup=failover serverversion=2.11.50

# run review-dne-part-1 with additional suites
testgroup=review-dne-part-1 testlist=sanity-lfsck,sanity-sec

testlist | String

Configure the test session to run a specific list of suites. testlist can be combined with testgroup to run a test group plus additional suites.

Valid values: sanity, sanityn, conf-sanity, mmp, replay-single, replay-dual, lnet-selftest, etc.

# run a custom list of suites
testlist=sanity,sanity-sec,sanity-hsm

# run review-dne-part-1 with additional suites
testlist=sanity-lfsck,sanity-sec testgroup=review-dne-part-1
timeoutreprovision | Boolean

Configures the session to re-provision all of the nodes instead of simply reboot them.

Valid values: true, false (no value is the same as true)

# re-provision nodes after a timeout
timeoutreprovision
# or
timeoutreprovision=true

# reboot the nodes after a timeout - typically not necessary since reboot is the default
timeoutreprovision=false
trivial | Boolean

The trivial keyword can be used to reduce the testing time (both wall-clock time as well as total test system hours) for patches that do not affect code functionality, such as changes to whitespace, comments, man pages, and test scripts (in conjunction with the testlist keyword to ensure the modified test script is run if it isn't already).  Patches marked with trivial in the Test-Parameters: list will run the review-ldiskfs test session instead of the regular tests, so it currently runs only sanity and lnet-selftest to ensure basic functionality.  If changes are only being made to a test script outside of those already run by default, an additional testlist=<test-script(s)>keyword should be added with a comma-separated list of modified tests to ensure they are run to validate the changes.  The trivial keyword will reduce the test completion time from approximately 10h elapsed and 30h of total test system time to approximately 3h elapsed/system time.  This saves test system resources that may be better spent on other patches.

Valid values: true, false (no value is the same as true)

# mark the patch as trivial
trivial
# or
trivial=true

# mark the patch as non-trivial - typically not necessary since this is the default
trivial=false


Node Parameters

Node parameters are used to change how specific node types are configured. They must be prefixed with the node type being changed. Valid node types are client, mds, mgs, oss and server. Server is an alias that allows users to modify a value for all server node types (mds, mgs and oss). For example instead of writing

mdsdistro=el7 mgsdistro=el7 ossdistro=el7

Users can simply write

serverdistro=el7
arch | String or Array

Sets the architecture for the specified node. This attribute can be a string to represent a single architecture for all of the nodes or an array when the architecture is mixed. When using an array of architectures the number of architectures must match the count attribute for the specified node type.

Valid values: x86_64, ppc64, aarch64 (architecture must have been built for patch)

# all clients will use x86_64
clientarch=x86_64

# 1 client will use ppc64 and 1 x86_64
clientarches=ppc64,x86_64 clientcount=2

# this would fail since 3 clients were requested and only 2 architectures listed
clientarches=ppc64,x86_64 clientcount=3

buildno | Integer

Used in conjunction with job to install a specific build on the specified node. job must be specified with buildno and version cannot be specified with buildno.

Valid values: Any valid Jenkins build number for the specified job

# install the server with a specific job/build combination
serverbuildno=343 serverjob=lustre-master 

# this would fail since serverjob is not specified
serverbuildno=343
count | Integer

The number of nodes to use for the specified node type.

NOTE: For MDS and OSS nodes, it's best to also set mdtcount / ostcount to ensure you have the expected number of targets.

Valid values:

clientcount2 - 4
mdscount1 - 4
osscount1 - 4
# configure session to run with 4 clients, 2 MDSs and 1 OSS
clientcount=4 mdscount=2 osscount=1
distro | String

Distribution to use for the specified node type.

Valid values: el7, el7.5, el7.6, ubuntu1604, ubuntu1804, sles12sp3, etc. (The distribution specified must have been built for the patch being tested. The distros built can be seen on the patch's build page in Jenkins.)

# specify the client to use el7 and all servers sles12sp3
clientdistro=el7 serverdistro=sles12sp3

# specify the client to use ubuntu1804, MDS to use el7 and OSS to use sles12sp3
clientdistro=ubuntu1804 mdsdistro=el7 ossdistro=sles12sp3
ibstack | String

The IB stack to use for the specified node type.

Valid values: inkernel, ofa (The IB stack type must have been built for the build being tested. The stack types can be seen on the patch's build page in Jenkins.)

clientibstack=inkernel

job | String

Used with buildno to install a specific build on the specified node. buildno must be specified with job. version cannot be specified with job.

Valid values: Any valid Jenkins job, such as lustre-reviews, lustre-master, etc.

# install the server with a specific job/build combination
serverjob=lustre-b2_10 serverbuildno=123

# this would fail since buildno is not specified for client
serverjob=lustre-b2_10 serverbuildno=123 clientjob=lustre-master
selinux | Boolean

Enables selinux on the specified node type.

Valid values: true, false (no value is the same as true)

# enables selinux on clients
clientselinux
# or
clientselinux=true

# disables selinux on clients - not typically necessary since false is the default
clientselinux=false

version | String

The version of Lustre to use for the specified node type.

NOTE: version cannot be specified with job and build

Valid values: For a list of valid versions see the Versions section.

# specify patch level versions
clientversion=2.10.3 serverversion=2.11.0

# specify minor versions which uses the highest patch level version
clientversion=2.10 serverversion=2.11


Versions

Versions are pointers to job/build combinations and simplify using a specific Lustre version on a test node. Versions can be specified in the test parameters using the version node parameter. If there is a version missing send an email to charlie@whamcloud.com



Test Groups

Test groups are set lists of Lustre test suites managed by Autotest.

Name

Suites

review-ldiskfs

lnet-selftest, sanity

review-dne-part-1

sanity, sanityn, recovery-small, lustre-rsync-test

review-dne-part-2

runtests, ost-pools, sanity-hsm, sanity-scrub, sanity-lfsck, sanity-sec, mds-survey, large-scale

review-dne-part-3

conf-sanity

review-dne-part-4

mmp, replay-single, sanity-pfl, sanity-flr, sanity-dom, sanity-quota, replay-ost-single, insanity

review-dne-zfs

runtests, sanity, sanityn, replay-single, conf-sanity, recovery-small, replay-ost-single, insanity, sanity-quota, lustre-rsync-test, ost-pools, sanity-lfsck, sanity-hsm

review-dne-zfs-part-1

sanity, sanityn, recovery-small, lustre-rsync-test

review-dne-zfs-part-2

runtests, ost-pools, sanity-hsm, sanity-scrub, sanity-lfsck, sanity-sec, mds-survey, large-scale

review-dne-zfs-part-3

conf-sanity

review-dne-zfs-part-4

mmp, replay-single, sanity-pfl, sanity-flr, sanity-dom, sanity-quota, replay-ost-single, insanity

review-zfs

sanity-quota, sanity-flr, replay-single, replay-ost-single, insanity

review-zfs-part-1

runtests, sanity, sanityn, sanity-quota, ost-pools, sanity-lfsck, sanity-hsm, sanity-flr

review-zfs-part-2

replay-single, conf-sanity, recovery-small, replay-ost-single, insanity, lustre-rsync-test, large-scale, mds-survey

review-ldiskfs-arm

sanity, lnet-selftest

failover

recovery-mds-scale, recovery-random-scale, recovery-double-scale, recovery-small, replay-ost-single, replay-dual, replay-vbr, mmp, replay-single

full

runtests, sanity, sanity-scrub, sanity-benchmark, sanity-lfsck, sanityn, sanity-hsm, sanity-flr, sanity-dom, sanity-lsnapshot, conf-sanity, racer, replay-single, recovery-small, replay-ost-single, replay-dual, replay-vbr, insanity, sanity-quota, sanity-sec, sanity-pfl, lustre-rsync-test, metadata-updates, ost-pools, mds-survey, mmp, performance-sanity, parallel-scale, large-scale, lnet-selftest, obdfilter-survey, parallel-scale-nfsv3, parallel-scale-nfsv4, posix

full-patchless

runtests, sanity, sanity-scrub, sanity-benchmark, sanity-lfsck, sanityn, sanity-hsm, sanity-flr, sanity-dom, sanity-lsnapshot, racer, insanity, sanity-quota, sanity-sec, sanity-pfl, lustre-rsync-test, metadata-updates, ost-pools, mds-survey, mmp, performance-sanity, parallel-scale, large-scale, lnet-selftest, obdfilter-survey, parallel-scale-nfsv3, parallel-scale-nfsv4, posix

regression

runtests, sanity, sanity-scrub, metadata-updates, sanity-benchmark, sanityn, lfsck, racer, replay-single, conf-sanity, recovery-small, replay-ost-single, replay-dual, replay-vbr, insanity, sanity-quota, ost-pools, mmp, lnet-selftest, obdfilter-survey, performance-sanity, parallel-scale, sanity-sec, lustre-rsync-test, parallel-scale-nfsv3, parallel-scale-nfsv4

review

runtests, sanity, sanityn, replay-single, conf-sanity, recovery-small, replay-ost-single, insanity, sanity-quota, lustre-rsync-test, ost-pools, lnet-selftest, sanity-lfsck, sanity-hsm

review-dne

runtests, sanity, sanityn, conf-sanity, recovery-small, replay-single, replay-ost-single, insanity, sanity-quota, sanity-sec, lustre-rsync-test, ost-pools, lnet-selftest, mmp, sanity-scrub, sanity-lfsck, sanity-hsm

review-mc

runtests, sanity, sanityn, replay-single, conf-sanity, recovery-small, replay-ost-single, insanity, sanity-quota, lustre-rsync-test, ost-pools, lnet-selftest, sanity-lfsck, sanity-hsm

tiny

sanity

basic

sanity, mmp, conf-sanity

development

metadata-updates

  • No labels

23 Comments

  1. Should "no_virtualization" be settable or should it be inferred by other settings, such as nettype=o2ib for example?  Ultimately, I'm not convinced that developers should know or care if testing is done on a VM or not.  Rather, how or what they want tested should determine that I think.  Performance tests are another example where no virtualization would be desired, but again, that's implied.

    1. I've removed no_virtualization because it made no sense and hasn't been in the code for months!

  2. Specifying the list of tests as a "dot-separated list" is fairly non-standard.  Would it be possible to specify this with either a space- or comma-separated list (possibly in quotes)?  Would it be easier to parse if all of the other parameters were one parameter per line?  I think that is actually easier for a human to read anyway.  Another alternative is to specify one parameter per line, to match the style of the other "Change-Id:", "Signed-off-by:", "Reviewed-by:", "Tested-by:", etc lines:

    Test-Parameter: ostcount=10
    Test-Parameter: nettype=tcp
    Test-Parameter: tests=conf-sanity,replay-single
    

    Should Gerrit block landing/merging a patch that has any Test-Parameters-Start or Test-Parameters-End stanza in it, so that the patch is sure to have passed the full test suite?  It potentially avoids cruft in the commit comments, though it is possibly also useful information about how the patch was tested.

    It should be possible to specify clientcount=1, I think.

    Looking at the parameters to be specified, it would be nice if there was a correspondence between these parameters and the ones used by the test scripts themselves, loaded from lustre/tests/cfg/config.sh.  This would allow expansion of the available parameters in a clear way in the future as needs arise.  Examples include OSTCOUNT (called "ostcount" above), NETTYPE ("nettype" above), PTLDEBUG, MDSSIZE, OSTSIZE, MDS_MKFS_OPT, OST_MKFS_OPT, and SLOW.  If the standard is that the Test-Parameter is named the same as the environment variable but in lower case, then this should be documented so that any parameters added later follow the same naming convention.  That said, the initial set seems like a reasonable starting point, and I'd rather have something to start with than wait longer for the Rolls Royce version.

    I can understand the need to avoid passing arbitrary environment straight through for security reasons, so it makes sense to limit the ones that can be set, and avoid shell escapes (`command` or $(command)) from being specified.

    As for "no_virtualization", I think this is reasonable to disable for performance tests, or in cases when there are timing-specific bugs.  It might make more sense to not have a negative option, and use "virtualization=no" (with "virtualization=yes" not _requiring_ it), but I'm not picky about this.

    1. Gerrit should certainly not block patches with Test-Parameters in it because people may well use this to ensure a particular feature. distro, arch etc is tested as part of the landing process. It add's value to know that these additional test requirements where asked for.

  3. One other question is whether the special tests should be in addition to the normal tests or instead of the regular tests?  My thought was that the specified builds/tests would be the only ones run, to reduce the load on the build/test nodes.  Then, once development of the patch is complete, it could be resubmitted without the Test-Parameter: lines to do a full set of tests, inspection, and landing.

    I'd also hope that the "Test-Parameter: clientdistro, clientarch, serverdistro, serverarch" lines would also limit the building of packages?  Currently we do 20 builds per commit, each one taking about 45 minutes, and if the patch is intended only for limited build/test there is less value to build it for all of the arch/distro combinations.

    1. Today using jenkins the builds are done in parallel and and so reducing the set doesn't neccessarily reduce the buildtime. The complexity of doing this with Jenkins would not be justified by the saving.

  4. Probably not directly related to this feature, but the ability to send notification mails only for review requests would be more desirable after this feature is up.  It would be even better if Gerrit could recognize submissions that change only "Test-Parameters-*" lines, so that identifying "real" revisions among "experimental" revisions.

  5. In many cases, if a developer just wants to run a quick test, it would be desirable to be able to specify:

    Test-Parameter: serverarch=any
    Test-Parameter: serverdistro=any
    

    so that the build/test will run on whatever build/test nodes are selected that have a short queue depth. This will help reduce turn-around time, and will also increase utilization of build/test nodes that would otherwise sit idle.

    I also realize that it should be possible to specify either of:

    Test-Parameter: serverarch=none
    Test-Parameter: serverdistro=none
    

    to cause a client-only build to be done (e.g. ./configure --disable-server) if that is all that is needed.

    1. The first 'any' doesn't make sense today because all test nodes are capable of all arch/distros and so do not factor into the test queue length. Perhaps in future this might become a possibility but not specifing something must mean any, so not putting a serverarch means any serverarch.

      We might want to look at directing builds rather than tests with this mechanism. If we did so I think explicitly calling out what you do want rather than what you do not makes more sense.

      BuildClientOnly

      for example.

  6. Chris,
    if there is the ability to set arbitrary environment variables, then most of the parameters specified here are not needed at all. I thought the point of having specific parameters was to isolate the test parameters to specific settings rather than allowing arbitrary changes to the test scripts and runtime environment.

    1. They are needed because they direct the test system, the environment variables are arbitrary as you say and the test system does not attempt to interpret them.

  7. What is the difference between "mdsfilesystemtype" and "mdtfilesystemtype"?

    1. They are defined in the test framework from autotest via the config file. How they are used is in the test framework.

      1. It seems "mdtfilesystemtype" should be "mgsfilesystemtype".

  8. It seems "useiscsi=true" needs to be changed to "iscsi=1".

     

  9. If I want to skip multiple test cases in sanity.sh, then how can I specify the "Test-Parameters" in the commit message? For example:

    Test-Parameters: envdefinitions=SANITY_EXCEPT="120 133" testlist=sanity

    Above line is reported as invalid.

  10. Just a guess, but you may be able to use Test-Parameters: envdefinitions="SANITY_EXCEPT='120 133'" testlist=sanity to properly pass the option to autotest.

  11. I have also ever tried "Test-Parameters: envdefinitions=SANITY_EXCEPT=\"120 133\" testlist=sanity", failed.

  12. There is no way to do this in the current version of autotest. Each line is split by spaces regardless of quotations. SANITY_EXCEPT=\"120 133\" will be evaluated as "SANITY_EXCEPT=120" and "133". 133 will be considered an invalid test-parameter and the patch will not be tested. If you'd like this to change, please enter a DCO ticket for enhancing the test-parameter parsing.

    1. DCO-5114

      Thanks!

  13. I specified "Test-Parameters: envdefinitions=SANITY_EXCEPT=101g" in the commit message, but the sanity_101g still has been run by Maloo.

    What's wrong?

  14. I removed mdsfilesystemtype from the list of Test-parameter options as it will be removed in the next Autotest deploy - see DCO-5866 for details. Current patches using the mdsfilesystemtype test-parameter will be valid and have the same effect until the next Autotest deploy. After the next Autotest deploy the mdsfilesystemtype test-parameter will still be accepted by Autotest, but not used. Please begin using mdtfilesystemtype instead.

  15. I hit the following error message and filed DCO-6433:

    Undefined variable serverbuildno used