Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

We're using Gerrit for code inspections and for managing changes to branches. The workflow for a change in Gerrit begins with an inspection request, and once the request has been approved, it is pushed directly to the branch by the gatekeeper. We don't need to manage patches externally, or manage our landing process using other tools - all of it can be done in Gerrit. Please review the Using Gerrit page for more details on how gerrit Gerrit and git Git are used together.

Requirements for patch submission

...

Please make sure the Change-Id: line are on and Signed-off-by: lines are at the bottom of the comment. This is also both required (as is the Signed-off- by line) by the fs/lustre-release project (at least) in order for the patch to be approved.  If your comments are excluding the Change-Id the missing either of these lines patch will be rejected at submission time. The   See Using Gerrit for a description of the Change-Id field should be added using the commit-msg hook, see belowline.

Example comment
No Format
LU-999 component: short description of change under 64 columns

A more detailed explanation.  This can be as detailed as you'd like.
Please explain both what problem was solved and a good high-level
description of how it was solved.  Wrap lines at 72 columns or less.

Signed-off-by: Random J Developer <random@developer.example.org>
Change-Id: Ica9ed1612eab0c4673dee088f8b441d806c64932

...