Versions Compared

Old Version 21

changes.mady.by.user Andreas Dilger

Saved on

compared with

New Version 22

changes.mady.by.user John Hammond

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • the entire commit message, including the summary line, should be copied from the source change
  • the Signed-off-by: line of the original author should also be kept
  • the person who commits the ported change should add a Signed-off-by: line with their name and email following the original one
  • the original Change-Id: line can be kept (newer Gerrit versions can handle the same Change-Id: line on different branches
  • the original Reviewed-by: lines can be kept, and Gerrit will automatically add them as reviewers to the new patch
  • the Tested-by: Maloo and Tested-by: Jenkins lines should be removed from the new commit message, though any Tested-by: lines from real people can be kept
  • the "Reviewed-on: http://review.whamcloud.com/nnnnn" line should be changed to "Lustre-change: http://review.whamcloud.com/nnnnn" (please use the "permalink" Gerrit URL as shown)
  • the "cherry picked from commit abcdef1234567890" line should be changed to  "Lustre-commit: abcdef1234567890"
  • any non-trivial changes to the original patch should be described after the original Signed-off-by: and Lustre-commit: lines before your own Signed-off-by: line
  • if two or more patches are being combined into a single patch (normally only when there are bugs in the original patch that were fixed in later commits) the full commit message from each patch should be kept, along with the Signed-off-by: and Lustre-commit: and Lustre-change: lines of each commit

...