Page History
...
- A JIRA ticket has been opened to track the issue
- Test and commit your patch locally using
acceptance-small.sh - The patch follows the Requirements for patch submission:
- The Commit Comments are well formatted and useful
- Verify patch follows Lustre Coding Guidelines (at least
"git show | build/checkpatch.pl -" passes) - A regression test has been created that fails without the patch and passes with the patch
- The patch has the appropriate signed off by line
- The patch has been uploaded to Gerrit
- Request at least two inspectors Patch Inspection approvals (preferably ones with experience in this area of code) on the Gerrit change
- Record the Gerrit change URL in the Jira ticket
- Additional test results appropriate for the patch being landed (interoperability, performance, etc) should be attached to the Jira ticket.
- Once Maloo has reported the tests all pass, add the branch gatekeeper Gerrit Gatekeeper as inspector on Gerrit the patch to notify him/her that the patch is ready to be merged
- The branch gatekeeper will review the patch, confirm the test results, and submit it when everything goes well
- If the submission failed due to patch conflict(s), the gatekeeper will ask you to rebase your patch with the target branch and repeat above steps.
- If your patch is needed for other branch(es), please repeat above steps against corresponding branch(es).
...
Overview
Content Tools