Page History
...
The commit summary line must be 62 characters or less, including the Jira ticket number and component tag, so that git shortlog and git format-patch can fit the summary onto a single line. The summary must be followed by a blank like. The rest of the comments should be wrapped to 70 columns or less. This allows for the first line to be used a subject in emails, and also for the entire body to be displayed using tools like git log or git shortlog in an 80 column window.
| No Format |
|---|
LU-nnn component: short description of change under 62 columns
The "component:" should be a lower-case single-word subsystem of the
Lustre code that best encompasses the change being made. Examples of
components include modules: llite, lov, lmv, osc, mdc, ldlm, lnet,
ptlrpc, mds, oss, osd-ldiskfs, ldiskfs, libcfs, socklnd, o2iblnd;
functional subsystems: recovery, quota, grant; and auxilliary areas:
build, tests, docs. This list is not exhaustive, but is a guideline.
The commit comment should contain a detailed explanation of changes
being made. This can be as long as you'd like. Please give details
of what problem was solved (including error messages or problems that
were seen), a good high-level description of how it was solved, and
which parts of the code were changed (including important functions
that were changed, if this is useful to understand the patch, and
for easier searching). Wrap lines at/under 70 columns.
Signed-off-by: Your Real Name <your_email@domain.name>
Change-Id: Ixxxx(added automatically if missing)xxxx
|
...
The Commit-Id: field is inserted automatically into the commit message by installing the build/commit-msg hook into each Git repository's .git/hooks/ directory. The build/prepare-commit-msg script should be installed as well. From the top-level Lustre tree checkout:
| No Format |
|---|
ln -sf ../../build/commit-msg .git/hooks/
ln -sf ../../build/prepare-commit-msg .git/hooks/
|
...
A number of additional commit tags can be used to further explain who has contributed to the patch, and for tracking purposes. These tags are commonly used with Linux kernel patches. These tags should appear before the Signed-off-by: tag.
| No Format |
|---|
Acked-by: User Name <user@domain.com> Tested-by: User Name <user@domain.com> Reported-by: User Name <user@domain.com> Reviewed-by: User Name <user@domain.com> CC: User Name <user@domain.com> {Organization}-bug-id: arbitrary bug tracking identifier |
| No Format |
Original-commit: {git commit hash of original patch}
Test-Parameters: additional testing parameters |
The {Organization}-bug-id: tag (e.g. Whamcloud-bug-id: ORI-123, Xyratex-bug-id: MRP-123, or Oracle-bug-id: b=12345) can be used to track this patch in other bug databases (e.g. bugzilla or internal bug databases).
Original-commit: is used to reference the original version of a patch that is being ported to another branch. Test-Parameters: is used to specify additional testing parameters for this patch, see Changing Test Parameters with Gerrit Commit Messages.
Examples of good commit comments
| No Format |
|---|
LU-477 ldiskfs: allocate s_group_desc/s_group_info by vmalloc()
Add the patch to the RHEL6 ldiskfs patch series.
Large kmalloc() for sbi->s_group_desc and sbi->s_group_info can fail
for large filesystems (typically over 16TB), which will cause the
"not enough memory" error while mounting. This patch makes allocation
fall back to vmalloc() if the kmalloc() failed, as what was done for
sbi->s_flex_groups.
To avoid colliding with an valid on-disk inode number, EXT4_BAD_INO
is used as the number of the buddy cache inode.
The patch also incorporates the following upstream kernel fix:
commit 32a9bb57d7c1fd04ae0f72b8f671501f000a0e9f
ext4: fix missing iput() of root inode for some mount error paths
https://bugzilla.kernel.org/show_bug.cgi?id=26752
Signed-off-by: Yu Jian <yujian whamcloud.com>
Change-Id: I3950425835ea7f2968ceb2edbc622e3ff3ed8545
|
| No Format |
|---|
LU-723 build: Enhance lustre/ldiskfs build system
Enhance the lustre/ldiskfs build system so it is more robust, flexible,
and consistent with lustre/zfs build system. This change is being made
in the interest of standardizing the infrastructure around backend
filesystems.
This change does not effect the current behavior of the --with-ldiskfs,
--enable-ext4, or --with-ldiskfsprogs configure options. However, it
does remove the obsolete --with-ldiskfs-inkernel configure option which
was only used by LLNL. It also adds the --with-ldiskfs-obj configure
option which improves flexibility. And the --enable-ldiskfs-build
configure option to support building against the lustre-ldiskfs-devel
package. The behavior of these options is consistent with their ZFS
counterparts, see commit 8c7266c for further details.
--enable-ext4 enable ldiskfs build using ext4
--enable-ldiskfs-build enable ldiskfs configure/make
--with-ldiskfs=path set path to ldiskfs source
--with-ldiskfs-obj=path set path to ldiskfs objects
--with-ldiskfsprogs use alternate names for ldiskfs-enabled e2fsprogs
Sample ./configure results when building lustre and ldiskfs using
the kernel-devel and kernel-debuginfo-common packages.
checking whether to enable ldiskfs... yes
checking ldiskfs source directory... /home/behlendo/src/git/lustre/ldiskfs
checking ldiskfs object directory... /home/behlendo/src/git/lustre/ldiskfs
checking ldiskfs module symbols... Module.symvers
checking ldiskfs source release... 3.3.0
checking whether to use ext3 or ext4 source... ext4
checking ext4 source directory... /usr/src/debug/.../fs/ext4
checking whether to build ldiskfs... yes
checking for /home/behlendo/src/git/lustre/ldiskfs/configure... yes
checking for /usr/src/debug/.../fs/ext4/dir.c... yes
checking for /usr/src/debug/.../fs/ext4/file.c... yes
checking for /usr/src/debug/.../fs/ext4/inode.c... yes
checking for /usr/src/debug/.../fs/ext4/super.c... yes
checking if ext4_ext_walk_space() takes i_data_sem... yes
checking if LDISKFS_SINGLEDATA_TRANS_BLOCKS takes sb as argument... yes
checking if ldiskfs_discard_preallocations defined... yes
checking if ldiskfs_ext_insert_extent needs 5 arguments... yes
In the context of this change additional cleanup has been done and
all of the ldiskfs specific code relocated to lustre-build-ldiskfs.m4.
Note that this change moves us closer to supporting patchless Lustre
servers with ldiskfs. Once the remaining kernel patches for Lustre
are dropped you will be able to build Lustre using the distribution
provided kernel-devel and kernel-debuginfo-common packages.
This change also incorporates ORI-340 commit f604951, which ensures
that the Module.symvers file will cleanly include the symbols for all
enabled Lustre backends. While the only backend supported by master
right now is ldiskfs this brings the master and orion branches into
sync in this regard.
Change-Id: I6f13f266944ec6967f4d7705a30b83ab8e577b15
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Prakash Surya <surya1@llnl.gov>
|
Overview
Content Tools